Skip to content

feat(hive): Build hive-metastore-opa-authorizer from source #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 17, 2025
Merged

feat(hive): Build hive-metastore-opa-authorizer from source #1340

merged 16 commits into from
Nov 17, 2025
+126 −14

Conversation

@maltesander
Copy link
Member

@maltesander maltesander commented Nov 7, 2025

Description

This adds the hive-metastore-opa-authorizer to the Hive docker image.

Build from source using patchable, forked to stackabletech.

For version 4.x.x the non shaded jar is used. The shaded one does not work (self-built or downloaded).

part of stackabletech/hive-operator#388

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

boil build <IMAGE> --image-version <RELEASE_VERSION> --strip-architecture --load
kind load docker-image <MANIFEST_URI> --name=<name-of-your-test-cluster>

See the output of boil to retrieve the image manifest URI for <MANIFEST_URI>.

@maltesander maltesander self-assigned this Nov 7, 2025
@maltesander maltesander mentioned this pull request Nov 7, 2025
Open
3 tasks
@maltesander maltesander moved this to Development: In Progress in Stackable Engineering Nov 7, 2025
@maltesander maltesander mentioned this pull request Nov 8, 2025
Open
20 tasks
@maltesander maltesander moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Nov 10, 2025
@dervoeti dervoeti self-requested a review November 13, 2025 07:59
@dervoeti dervoeti moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Nov 13, 2025
dervoeti
dervoeti reviewed Nov 13, 2025
View reviewed changes
Copy link
Member

@dervoeti dervoeti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, three remarks:

  1. Hive 4.0.0 was removed. Was that intentional? If yes, I would mention it in the changelog.
  2. We should use our patched version of Hadoop to build hive-metastore-opa-authorizer, like we do in Hive itself (the JARS are copied with this command, so Maven uses these local JARs instead of pulling the original ones)
  3. pre-commit complains: https://github.com/stackabletech/docker-images/actions/runs/19209697811/job/54910095564?pr=1340

fetzerms
fetzerms reviewed Nov 17, 2025
View reviewed changes
@maltesander
Copy link
Member Author

maltesander commented Nov 17, 2025

Works fine, three remarks:

1. Hive 4.0.0 was removed. Was that intentional? If yes, I would mention it in the changelog.

2. We should use our patched version of Hadoop to build hive-metastore-opa-authorizer, like we do in [Hive itself](https://github.com/stackabletech/docker-images/blob/576b002f73ca41bb839a70535db16f97c9818e17/hive/Dockerfile#L36) (the JARS are copied [with this command](https://github.com/stackabletech/docker-images/blob/576b002f73ca41bb839a70535db16f97c9818e17/hive/Dockerfile#L56), so Maven uses these local JARs instead of pulling the original ones)

3. pre-commit complains: https://github.com/stackabletech/docker-images/actions/runs/19209697811/job/54910095564?pr=1340
  1. Yes 4.0.0 was removed intentionally. Added changelog entry 83b4bca.
  2. Added local jars command
  3. Doing that regex comparison in pure "sh" is just ugly. I explicitly use bash via
# Use bash for regex machting, otherwise docker lint is complaining:
# hive/hive-metastore-opa-authorizer/Dockerfile:26 SC3015 warning: In POSIX sh, =~ regex matching is undefined.
SHELL ["/bin/bash", "-c"]

@maltesander maltesander requested a review from dervoeti November 17, 2025 13:59
@maltesander maltesander added this pull request to the merge queue Nov 17, 2025
@maltesander maltesander moved this from Development: In Review to Development: Done in Stackable Engineering Nov 17, 2025
Merged via the queue into main with commit 4bb1899 Nov 17, 2025
3 checks passed
@maltesander maltesander deleted the feat/add-and-build-opa-authorizer-from-source branch November 17, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dervoeti dervoeti dervoeti approved these changes

+1 more reviewer

@fetzerms fetzerms fetzerms left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@maltesander maltesander

Labels

None yet

Projects

Stackable Engineering
Status: Development: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maltesander @fetzerms @dervoeti